fix(desktop,acp): Codex model discovery timeout UX + 45s probe budget#2267
Open
tzarebczan wants to merge 2 commits into
Open
fix(desktop,acp): Codex model discovery timeout UX + 45s probe budget#2267tzarebczan wants to merge 2 commits into
tzarebczan wants to merge 2 commits into
Conversation
Raise buzz-acp models probe timeout from 10s to 45s so Windows Codex cold starts can finish. Surface progressive under-field copy after 10s, clear timeout/PATH errors with Retry, and keep the model control on a short loading label so long status text is never truncated in the pill. Builds on block#2246 (status bypass + empty non-cache). Fixes block#2261. Signed-off-by: Thomas Zarebczan <thomas.zarebczan@gmail.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ee5327a910
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Force edit/create model controls onto the short loading sentinel while probing so the closed trigger is not stuck on a stale default with no cue. Use MODEL_DISCOVERY_LOADING_SHORT in shared modelDropdownOptions. Mark Runtime-not-available discovery status non-retryable so Retry is not a no-op without discoverAgentModels. Signed-off-by: Thomas Zarebczan <thomas.zarebczan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buzz-acp modelsMODELS_TIMEOUTfrom 10s → 45s so Windows Codex ACP cold starts (~15–25s) can finish instead of returning empty models.retryable+ sharedModelDiscoveryStatusLine).Fixes #2261.
Context
Codex ACP boots the Codex App Server on each
modelsprobe. Product assumed ~2–5s; Windows cold path often exceeds the old 10s budget. Related install/PATH work remains separate (#2238).Test plan
personaModelDiscoveryStatus,usePersonaModelDiscovery,agentConfigFieldsContract,agentConfigControlstests.Notes